slimbus: core: do not call device_status under a lock

Calling device_status callback under a lock would prevent drivers
to do any slimbus trasactions which would invoke this lock like
get_laddr(). Remove this unnecessary lock!

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 9e4f3b21ba8c0987da8ee8e8f4bbbb7ae3ac36fb..1ba08b5f2e78b14ad9536dc913023e746987dde4 100644 (file)
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -466,6 +466,7 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
 
        sbdev->laddr = laddr;
        sbdev->is_laddr_valid = true;
+       mutex_unlock(&ctrl->lock);
 
        slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP);
 
@@ -473,6 +474,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
                laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code,
                sbdev->e_addr.dev_index, sbdev->e_addr.instance);
 
+       return 0;
+
 err:
        mutex_unlock(&ctrl->lock);
        return ret;