drm/tegra: dc: Add missing of_node_put()
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 24 Oct 2015 14:42:31 +0000 (16:42 +0200)
committerThierry Reding <treding@nvidia.com>
Mon, 14 Dec 2015 10:40:55 +0000 (11:40 +0100)
for_each_matching_node() performs an of_node_get() on each iteration, so
a break out of the loop requires an of_node_put().

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_matching_node(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/dc.c

index e9f24a85a1038701cc819f38e9b0318260e6679d..ea174b5a649d79b869a7301962dbf8c194b1ebcd 100644 (file)
@@ -1952,8 +1952,10 @@ static int tegra_dc_parse_dt(struct tegra_dc *dc)
                 * cases where only a single display controller is used.
                 */
                for_each_matching_node(np, tegra_dc_of_match) {
-                       if (np == dc->dev->of_node)
+                       if (np == dc->dev->of_node) {
+                               of_node_put(np);
                                break;
+                       }
 
                        value++;
                }