libertas: don't block usb8388 suspend if no wakeup conditions are set
authorDaniel Drake <dsd@laptop.org>
Sun, 31 Oct 2010 13:40:12 +0000 (13:40 +0000)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 16 Nov 2010 21:37:02 +0000 (16:37 -0500)
This hunk added by commit 66fceb69b72f seems erroneous. We don't want to
prevent suspend of the whole system if no wakeup params are set.

In the case of the usb8388 we do want to keep the card powered up even
if there are no wakeup params. This is because it will continue acting
as a mesh node.

If the mesh is disabled, it would indeed make more sense to power down
the card during suspend, as the equivalent hunk does for the SD interface.
But that's a separate task; for now just restore the previous behaviour.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/if_usb.c

index efaf850322089b3f6ef1c40219dc547020976767..35931cf4d6dbe8e7dd9acc620f98a5ec72819e10 100644 (file)
@@ -1090,12 +1090,6 @@ static int if_usb_suspend(struct usb_interface *intf, pm_message_t message)
        if (priv->psstate != PS_STATE_FULL_POWER)
                return -1;
 
-       if (priv->wol_criteria == EHS_REMOVE_WAKEUP) {
-               lbs_pr_info("Suspend attempt without "
-                                               "configuring wake params!\n");
-               return -ENOSYS;
-       }
-
        ret = lbs_suspend(priv);
        if (ret)
                goto out;