staging: rtl8188eu: remove unneeded variable
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Thu, 16 Jul 2015 11:28:10 +0000 (16:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Jul 2015 17:18:09 +0000 (10:18 -0700)
The default value of status was _FAIL, it was only changed if kzalloc
succeeds and the check for status is immediately following kzalloc. We
can have the failure code in the else part as the failure code will be
executed only if kzalloc fails.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/os_dep/usb_intf.c

index f68875bd95119e8502560a186be020b984fef2e4..2d75c77c8cdbc24a8d143cacd492bc6bd1235c22 100644 (file)
@@ -55,7 +55,6 @@ MODULE_DEVICE_TABLE(usb, rtw_usb_id_tbl);
 static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
 {
        int     i;
-       int     status = _FAIL;
        struct dvobj_priv *pdvobjpriv;
        struct usb_host_config          *phost_conf;
        struct usb_config_descriptor    *pconf_desc;
@@ -117,10 +116,7 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
 
        if (pdvobjpriv->usb_vendor_req_buf) {
                usb_get_dev(pusbd);
-               status = _SUCCESS;
-       }
-
-       if (status != _SUCCESS) {
+       } else {
                usb_set_intfdata(usb_intf, NULL);
                kfree(pdvobjpriv);
                pdvobjpriv = NULL;