bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
authorColy Li <colyli@suse.de>
Tue, 30 Apr 2019 14:02:25 +0000 (22:02 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 30 Apr 2019 14:20:46 +0000 (08:20 -0600)
Commit 95f18c9d1310 ("bcache: avoid potential memleak of list of
journal_replay(s) in the CACHE_SYNC branch of run_cache_set") forgets
to remove the original define of LIST_HEAD(journal), which makes
the change no take effect. This patch removes redundant variable
LIST_HEAD(journal) from run_cache_set(), to make Shenghui's fix
working.

Fixes: 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set")
Reported-by: Juha Aatrokoski <juha.aatrokoski@aalto.fi>
Cc: Shenghui Wang <shhuiw@foxmail.com>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c

index 0ffe9acee9d8ae4ceaf34b6a6c58dc85211e2137..1b63ac876169ed02aab084a0e6bb69f28e823974 100644 (file)
@@ -1800,7 +1800,6 @@ static int run_cache_set(struct cache_set *c)
        set_gc_sectors(c);
 
        if (CACHE_SYNC(&c->sb)) {
-               LIST_HEAD(journal);
                struct bkey *k;
                struct jset *j;