drm/amd/powerplay: init table_count for smu tables on asic level
authorHuang Rui <ray.huang@amd.com>
Fri, 29 Mar 2019 10:07:23 +0000 (18:07 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 21 Jun 2019 23:59:26 +0000 (18:59 -0500)
TABLE_COUNT should be inited in asic level. Because the value may be different
on each asic even on the same ip.

Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Kevin Wang <kevin1.wang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/navi10_ppt.c
drivers/gpu/drm/amd/powerplay/smu_v11_0.c
drivers/gpu/drm/amd/powerplay/vega20_ppt.c

index f1797ab0bcc5cfaea2b08ae776b6f240d6a68da1..722e0a9c241643d9db8fe3b857002a3b9b177c1d 100644 (file)
@@ -447,6 +447,9 @@ static const struct pptable_funcs navi10_ppt_funcs = {
 
 void navi10_set_ppt_funcs(struct smu_context *smu)
 {
+       struct smu_table_context *smu_table = &smu->smu_table;
+
        smu->ppt_funcs = &navi10_ppt_funcs;
        smu->smc_if_version = SMU11_DRIVER_IF_VERSION;
+       smu_table->table_count = TABLE_COUNT;
 }
index 0d096e89992805765bec2afefef627ae08a53eaf..e6f166a4a6729e4f5d1f6a73f32477f05f2a7aad 100644 (file)
@@ -400,15 +400,15 @@ static int smu_v11_0_init_smc_tables(struct smu_context *smu)
        struct smu_table *tables = NULL;
        int ret = 0;
 
-       if (smu_table->tables || smu_table->table_count != 0)
+       if (smu_table->tables || smu_table->table_count == 0)
                return -EINVAL;
 
-       tables = kcalloc(TABLE_COUNT, sizeof(struct smu_table), GFP_KERNEL);
+       tables = kcalloc(SMU_TABLE_COUNT, sizeof(struct smu_table),
+                        GFP_KERNEL);
        if (!tables)
                return -ENOMEM;
 
        smu_table->tables = tables;
-       smu_table->table_count = TABLE_COUNT;
 
        SMU_TABLE_INIT(tables, TABLE_PPTABLE, sizeof(PPTable_t),
                       PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
index 7cafbc942b2a24e2fdda09fe2588cd4c6f55dd43..17a954bd5aa48b4a7095c8ca8e69636dbe6f5e2d 100644 (file)
@@ -2989,6 +2989,9 @@ static const struct pptable_funcs vega20_ppt_funcs = {
 
 void vega20_set_ppt_funcs(struct smu_context *smu)
 {
+       struct smu_table_context *smu_table = &smu->smu_table;
+
        smu->ppt_funcs = &vega20_ppt_funcs;
        smu->smc_if_version = SMU11_DRIVER_IF_VERSION;
+       smu_table->table_count = TABLE_COUNT;
 }