net: cacheline adjust struct netns_frags for better frag performance
authorJesper Dangaard Brouer <brouer@redhat.com>
Mon, 28 Jan 2013 23:44:14 +0000 (23:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Jan 2013 18:36:23 +0000 (13:36 -0500)
This small cacheline adjustment of struct netns_frags improves
performance significantly for the fragmentation code.

Struct members 'lru_list' and 'mem' are both hot elements, and it
hurts performance, due to cacheline bouncing at every call point,
when they share a cacheline.  Also notice, how mem is placed
together with 'high_thresh' and 'low_thresh', as they are used in
the compare operations together.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/inet_frag.h

index 32786a0447187f44e1264f4dc4c0b4721ebc3e08..91e77975eaa612328301076c73d3a6b6fb482118 100644 (file)
@@ -3,9 +3,12 @@
 
 struct netns_frags {
        int                     nqueues;
-       atomic_t                mem;
        struct list_head        lru_list;
 
+       /* Its important for performance to keep lru_list and mem on
+        * separate cachelines
+        */
+       atomic_t                mem ____cacheline_aligned_in_smp;
        /* sysctls */
        int                     timeout;
        int                     high_thresh;