iio: trigger: Fix platform_get_irq's error checking
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 30 Nov 2017 15:43:34 +0000 (21:13 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 2 Dec 2017 12:21:10 +0000 (12:21 +0000)
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/trigger/iio-trig-bfin-timer.c

index d80dcf82eba92c32a98e7e777694aa10090772ab..f389f5cca99d6151d635f50794ba1472237b0aac 100644 (file)
@@ -187,9 +187,9 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        st->irq = platform_get_irq(pdev, 0);
-       if (!st->irq) {
+       if (st->irq < 0) {
                dev_err(&pdev->dev, "No IRQs specified");
-               return -ENODEV;
+               return st->irq;
        }
 
        ret = iio_bfin_tmr_get_number(st->irq);