[PATCH] proc: inode number fixlet
authorAlexey Dobriyan <adobriyan@gmail.com>
Sat, 2 Aug 2008 03:30:48 +0000 (07:30 +0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 25 Aug 2008 05:18:03 +0000 (01:18 -0400)
Ouch, if number taken from IDA is too big, the intent was to signal an
error, not check for overflow and still do overflowing addition.

One still needs 2^28 proc entries to notice this.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/proc/generic.c

index 4fb81e9c94e3b616745bd696394e6909ec46b5bf..bca0f81eb6876fba681f3db8dedd9788887e93b5 100644 (file)
@@ -330,6 +330,7 @@ retry:
                spin_lock(&proc_inum_lock);
                ida_remove(&proc_inum_ida, i);
                spin_unlock(&proc_inum_lock);
+               return 0;
        }
        return PROC_DYNAMIC_FIRST + i;
 }