drm/atmel-hlcdc: revert shift by 8
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Thu, 25 Apr 2019 12:36:39 +0000 (12:36 +0000)
committerSam Ravnborg <sam@ravnborg.org>
Tue, 4 Jun 2019 21:52:09 +0000 (23:52 +0200)
Revert shift by 8 of state->base.alpha. This introduced a
regression on planes.

Fixes: 7f73c10b256b ("drm/atmel-hclcdc: Convert to the new generic alpha property")
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1556195748-11106-7-git-send-email-claudiu.beznea@microchip.com
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c

index fdd607ad27feefd50fd244f379fc1ed052b2bc06..0ee5b7a3a4b0fdfccda0103f0c1fb1adb43a2262 100644 (file)
@@ -382,7 +382,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
                        cfg |= ATMEL_HLCDC_LAYER_LAEN;
                else
                        cfg |= ATMEL_HLCDC_LAYER_GAEN |
-                              ATMEL_HLCDC_LAYER_GA(state->base.alpha >> 8);
+                              ATMEL_HLCDC_LAYER_GA(state->base.alpha);
        }
 
        if (state->disc_h && state->disc_w)