ice: Bug fixes in ethtool code
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Mon, 2 Apr 2018 16:26:06 +0000 (09:26 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 6 Apr 2018 14:00:09 +0000 (07:00 -0700)
1) Return correct size from ice_get_regs_len.
2) Fix incorrect use of ARRAY_SIZE in ice_get_regs.

Fixes: fcea6f3da546 (ice: Add stats and ethtool support)
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_ethtool.c

index 186764a5c2636691ce81da4cbd42791186c69573..1db304c01d100604560a5d4ac8216b093a7f92d6 100644 (file)
@@ -156,7 +156,7 @@ ice_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 
 static int ice_get_regs_len(struct net_device __always_unused *netdev)
 {
-       return ARRAY_SIZE(ice_regs_dump_list);
+       return sizeof(ice_regs_dump_list);
 }
 
 static void
@@ -170,7 +170,7 @@ ice_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *p)
 
        regs->version = 1;
 
-       for (i = 0; i < ARRAY_SIZE(ice_regs_dump_list) / sizeof(u32); ++i)
+       for (i = 0; i < ARRAY_SIZE(ice_regs_dump_list); ++i)
                regs_buf[i] = rd32(hw, ice_regs_dump_list[i]);
 }