ASoC: Intel: Skylake: Disable notifications at boot after DSP FW init
authorG Kranthi <gudishax.kranthikumar@intel.com>
Mon, 13 Mar 2017 16:41:29 +0000 (22:11 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 15 Mar 2017 17:28:11 +0000 (17:28 +0000)
DSP firmware sends notification every 1ms, which is disabled in runtime
suspend. But if a system has no runtime pm, we keep getting
notification, so disable after FW init as well.

Signed-off-by: G Kranthi <gudishax.kranthikumar@intel.com>
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-messages.c
sound/soc/intel/skylake/skl-pcm.c
sound/soc/intel/skylake/skl-sst-dsp.h

index ed576965caccbe1aa2533dbb4093e232971d2df2..29523ddcfab06a36cd369b61a4d676b9c08c1474 100644 (file)
@@ -58,7 +58,7 @@ static int skl_free_dma_buf(struct device *dev, struct snd_dma_buffer *dmab)
 #define NOTIFICATION_MASK 0xf
 
 /* disable notfication for underruns/overruns from firmware module */
-static void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable)
+void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable)
 {
        struct notification_mask mask;
        struct skl_ipc_large_config_msg msg = {0};
index e3d206d50f3e0b0f34cc9392c09e48e3b71f081f..2f90bc40be77ca56378e9785b40754924777215a 100644 (file)
@@ -1214,6 +1214,7 @@ static int skl_platform_soc_probe(struct snd_soc_platform *platform)
                }
                skl_populate_modules(skl);
                skl->skl_sst->update_d0i3c = skl_update_d0i3c;
+               skl_dsp_enable_notification(skl->skl_sst, false);
        }
        pm_runtime_mark_last_busy(platform->dev);
        pm_runtime_put_autosuspend(platform->dev);
index 849410d0823e96ec4cd658263cb0aaeb254a5397..e8d1e149e0cd9376f8580e226bb8075f50bd14ee 100644 (file)
@@ -235,4 +235,6 @@ int skl_get_pvt_instance_id_map(struct skl_sst *ctx,
 void skl_freeup_uuid_list(struct skl_sst *ctx);
 
 int skl_dsp_strip_extended_manifest(struct firmware *fw);
+void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable);
+
 #endif /*__SKL_SST_DSP_H__*/