misc: eeprom_93xx46: Fix 16-bit read and write accesses.
authorCory Tusar <cory.tusar@pid1solutions.com>
Thu, 7 Jan 2016 03:55:00 +0000 (22:55 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Feb 2016 01:27:45 +0000 (17:27 -0800)
Compatible at93xx46 devices from both Microchip and Atmel expect a
word-based address, regardless of whether the device is strapped for 8-
or 16-bit operation.  However, the offset parameter passed in when
reading or writing at a specific location is always specified in terms
of bytes.

This commit fixes 16-bit read and write accesses by shifting the offset
parameter to account for this difference between a byte offset and a
word-based address.

Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
Tested-by: Chris Healy <chris.healy@zii.aero>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/eeprom_93xx46.c

index 473aa0a2eaf61fe2743c821be88cbb8baaaab1ce..da3c081c2639afc3640d1a1b77fc6546e72d62ff 100644 (file)
@@ -54,7 +54,7 @@ eeprom_93xx46_bin_read(struct file *filp, struct kobject *kobj,
                cmd_addr |= off & 0x7f;
                bits = 10;
        } else {
-               cmd_addr |= off & 0x3f;
+               cmd_addr |= (off >> 1) & 0x3f;
                bits = 9;
        }
 
@@ -155,7 +155,7 @@ eeprom_93xx46_write_word(struct eeprom_93xx46_dev *edev,
                bits = 10;
                data_len = 1;
        } else {
-               cmd_addr |= off & 0x3f;
+               cmd_addr |= (off >> 1) & 0x3f;
                bits = 9;
                data_len = 2;
        }