tty: Fix tty_port kref screwup
authorAlan Cox <alan@redhat.com>
Tue, 21 Oct 2008 12:47:44 +0000 (13:47 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 23 Oct 2008 16:20:53 +0000 (09:20 -0700)
Pass the brown paper bags please. I changed the semantics of this so the
function was supposed to do the extra kref itself then forgot to do the
change.. duh....

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/tty_port.c

index 553b0e9d8d17a5513747337ddf5bcf49caaba95b..c8f8024cb40e5d6b4fcc6ad1a8f4408104e9f81a 100644 (file)
@@ -90,7 +90,7 @@ void tty_port_tty_set(struct tty_port *port, struct tty_struct *tty)
        spin_lock_irqsave(&port->lock, flags);
        if (port->tty)
                tty_kref_put(port->tty);
-       port->tty = tty;
+       port->tty = tty_kref_get(tty);
        spin_unlock_irqrestore(&port->lock, flags);
 }
 EXPORT_SYMBOL(tty_port_tty_set);