perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0
authorJiri Olsa <jolsa@kernel.org>
Mon, 27 Aug 2018 09:12:26 +0000 (11:12 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 30 Aug 2018 17:49:23 +0000 (14:49 -0300)
Once the breakpoint was succesfully modified, the attr->disabled value
is in bp->attr.disabled. So there's no reason to set it again, removing
that.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Milind Chabbi <chabbi.milind@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180827091228.2878-4-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
kernel/events/hw_breakpoint.c

index fb229d9c7f3c9437866638cfec5705af73ba3733..3e560d7609fd23274e66c73b442df1d4195bf025 100644 (file)
@@ -526,10 +526,9 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att
        if (err)
                return err;
 
-       if (!attr->disabled) {
+       if (!attr->disabled)
                perf_event_enable(bp);
-               bp->attr.disabled = 0;
-       }
+
        return 0;
 }
 EXPORT_SYMBOL_GPL(modify_user_hw_breakpoint);