xen-netfront: Fix mismatched rtnl_unlock
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Thu, 21 Jun 2018 13:00:20 +0000 (14:00 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Jun 2018 22:54:54 +0000 (07:54 +0900)
Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open")
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netfront.c

index 922ce0abf5cf105a5394285b07356ebcad055d78..ee4cb6cfde1ec875e3e1b395098929f058271f51 100644 (file)
@@ -1810,7 +1810,7 @@ static int talk_to_netback(struct xenbus_device *dev,
        err = xen_net_read_mac(dev, info->netdev->dev_addr);
        if (err) {
                xenbus_dev_fatal(dev, err, "parsing %s/mac", dev->nodename);
-               goto out;
+               goto out_unlocked;
        }
 
        rtnl_lock();
@@ -1925,6 +1925,7 @@ abort_transaction_no_dev_fatal:
        xennet_destroy_queues(info);
  out:
        rtnl_unlock();
+out_unlocked:
        device_unregister(&dev->dev);
        return err;
 }