platform/x86: intel-vbtn: Report switch events when event wakes device
authorMathew King <mathewk@chromium.org>
Mon, 20 May 2019 22:41:24 +0000 (16:41 -0600)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 12 Jun 2019 08:49:20 +0000 (11:49 +0300)
When a switch event, such as tablet mode/laptop mode or docked/undocked,
wakes a device make sure that the value of the swich is reported.
Without when a device is put in tablet mode from laptop mode when it is
suspended or vice versa the device will wake up but mode will be
incorrect.

Tested by suspending a device in laptop mode and putting it in tablet
mode, the device resumes and is in tablet mode. When suspending the
device in tablet mode and putting it in laptop mode the device resumes
and is in laptop mode.

Signed-off-by: Mathew King <mathewk@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel-vbtn.c

index 06cd7e818ed5dd8b9c28c5f67289d8dc90b07644..a0d0cecff55fd908a3b3096238c529a2ed657217 100644 (file)
@@ -76,12 +76,24 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
        struct platform_device *device = context;
        struct intel_vbtn_priv *priv = dev_get_drvdata(&device->dev);
        unsigned int val = !(event & 1); /* Even=press, Odd=release */
-       const struct key_entry *ke_rel;
+       const struct key_entry *ke, *ke_rel;
        bool autorelease;
 
        if (priv->wakeup_mode) {
-               if (sparse_keymap_entry_from_scancode(priv->input_dev, event)) {
+               ke = sparse_keymap_entry_from_scancode(priv->input_dev, event);
+               if (ke) {
                        pm_wakeup_hard_event(&device->dev);
+
+                       /*
+                        * Switch events like tablet mode will wake the device
+                        * and report the new switch position to the input
+                        * subsystem.
+                        */
+                       if (ke->type == KE_SW)
+                               sparse_keymap_report_event(priv->input_dev,
+                                                          event,
+                                                          val,
+                                                          0);
                        return;
                }
                goto out_unknown;