projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
709e715
)
cxgb4: Add missing annotation for service_ofldq()
author
Jules Irenge
<jbi.octave@gmail.com>
Wed, 29 Apr 2020 22:57:22 +0000
(23:57 +0100)
committer
David S. Miller
<davem@davemloft.net>
Fri, 1 May 2020 22:31:37 +0000
(15:31 -0700)
Sparse reports a warning at service_ofldq()
warning: context imbalance in service_ofldq() - unexpected unlock
The root cause is the missing annotation at service_ofldq()
Add the missing __must_hold(&q->sendq.lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/sge.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/chelsio/cxgb4/sge.c
b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index 2cfb1f691bf266778c677e0c7ed03db056bd7259..6516c45864b359b53e37a8a44e475b6b9b1f7c17 100644
(file)
--- a/
drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/
drivers/net/ethernet/chelsio/cxgb4/sge.c
@@
-2728,6
+2728,7
@@
static void ofldtxq_stop(struct sge_uld_txq *q, struct fw_wr_hdr *wr)
* is ever running at a time ...
*/
static void service_ofldq(struct sge_uld_txq *q)
+ __must_hold(&q->sendq.lock)
{
u64 *pos, *before, *end;
int credits;