ASoC: amd: memory release for rtd structure
authorMukunda, Vijendar <Vijendar.Mukunda@amd.com>
Tue, 8 May 2018 04:47:49 +0000 (10:17 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 21 May 2018 15:19:04 +0000 (16:19 +0100)
rtd structure freed early may result in kernel panic in dma close
call back. moved releasing memory for rtd structure to the end of
dma close callback.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp-pcm-dma.c

index 39cd54f1b493f98f1cbff3fe5d16a9211f223be8..1c44b26ad2dbb5e30a73e1274088065c1a18ed60 100644 (file)
@@ -998,8 +998,6 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
                                                                    DRV_NAME);
        struct audio_drv_data *adata = dev_get_drvdata(component->dev);
 
-       kfree(rtd);
-
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
                adata->play_i2ssp_stream = NULL;
                /*
@@ -1028,7 +1026,7 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
         */
        if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream)
                acp_reg_write(0, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
-
+       kfree(rtd);
        return 0;
 }