scsi: storvsc: missing error code in storvsc_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 16 Jan 2018 10:40:22 +0000 (13:40 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 Jan 2018 06:16:30 +0000 (01:16 -0500)
We should set the error code if fc_remote_port_add() fails.

Cc: <stable@vger.kernel.org> #v4.12+
Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Cathy Avery <cavery@redhat.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c

index 1b06cf0375dcdbd6f1780ab7535bbaa4c5742916..e07907d91d0400a3b1e10f6c97c37a411d5103cc 100644 (file)
@@ -1833,8 +1833,10 @@ static int storvsc_probe(struct hv_device *device,
                fc_host_node_name(host) = stor_device->node_name;
                fc_host_port_name(host) = stor_device->port_name;
                stor_device->rport = fc_remote_port_add(host, 0, &ids);
-               if (!stor_device->rport)
+               if (!stor_device->rport) {
+                       ret = -ENOMEM;
                        goto err_out4;
+               }
        }
 #endif
        return 0;