nvmem: core: return error code instead of NULL from nvmem_device_get
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tue, 7 Aug 2018 12:19:35 +0000 (13:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Sep 2018 07:46:46 +0000 (09:46 +0200)
nvmem_device_get() should return ERR_PTR() on error or valid pointer
on success, but one of the code path seems to return NULL, so fix it.

Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/core.c

index aa1657831b70c2ca5075d1b580c32564c29b6a42..6f064002f439648079a1f330f488c8714f370f5b 100644 (file)
@@ -679,7 +679,7 @@ static struct nvmem_device *nvmem_find(const char *name)
        d = bus_find_device_by_name(&nvmem_bus_type, NULL, name);
 
        if (!d)
-               return NULL;
+               return ERR_PTR(-ENOENT);
 
        return to_nvmem_device(d);
 }