ASoC: atmel: atmel-classd: consider CPU-Platform possibility
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 28 Jun 2019 01:46:19 +0000 (10:46 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 28 Jun 2019 14:09:19 +0000 (15:09 +0100)
commit 02602401e5316 ("ASoC: atmel: atmel-classd: don't select
unnecessary Platform")

Current ALSA SoC avoid to add duplicate component to rtd,
and this driver was selecting CPU component as Platform component.
Thus, above patch removed Platform settings from this driver,
because it assumed these are same component.

But, some CPU driver is using generic DMAEngine, in such case, both
CPU component and Platform component will have same of_node/name.
In other words, there are some components which are different but
have same of_node/name.

In such case, Card driver definitely need to select Platform even
though it is same as CPU.
It is depends on CPU driver, but is difficult to know it from Card driver.
This patch reverts above patch.

Fixes: commit 02602401e5316 ("ASoC: atmel: atmel-classd: don't select unnecessary Platform")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/atmel-classd.c

index a2390e9b97c79a5de0155a9b027e4f8361d2faef..0f2c574f27f11316509b31579c7b551312df3903 100644 (file)
@@ -503,21 +503,24 @@ static int atmel_classd_asoc_card_init(struct device *dev,
        if (!dai_link)
                return -ENOMEM;
 
-       comp = devm_kzalloc(dev, 2 * sizeof(*comp), GFP_KERNEL);
+       comp = devm_kzalloc(dev, 3 * sizeof(*comp), GFP_KERNEL);
        if (!comp)
                return -ENOMEM;
 
        dai_link->cpus          = &comp[0];
        dai_link->codecs        = &comp[1];
+       dai_link->platforms     = &comp[2];
 
        dai_link->num_cpus      = 1;
        dai_link->num_codecs    = 1;
+       dai_link->num_platforms = 1;
 
        dai_link->name                  = "CLASSD";
        dai_link->stream_name           = "CLASSD PCM";
        dai_link->codecs->dai_name      = ATMEL_CLASSD_CODEC_DAI_NAME;
        dai_link->cpus->dai_name        = dev_name(dev);
        dai_link->codecs->name          = dev_name(dev);
+       dai_link->platforms->name       = dev_name(dev);
 
        card->dai_link  = dai_link;
        card->num_links = 1;