drm/i915: add for_each_hpd_pin to iterate over hotplug pins
authorJani Nikula <jani.nikula@intel.com>
Thu, 28 May 2015 12:43:48 +0000 (15:43 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 29 May 2015 08:15:29 +0000 (10:15 +0200)
No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_irq.c

index 173c9051bf86e0fc0635b14d7117ab01be8c3383..60aa9626f91fa92682ee345bcb92612175a0b43e 100644 (file)
@@ -217,6 +217,9 @@ enum hpd_pin {
        HPD_NUM_PINS
 };
 
+#define for_each_hpd_pin(__pin) \
+       for ((__pin) = (HPD_NONE + 1); (__pin) < HPD_NUM_PINS; (__pin)++)
+
 struct i915_hotplug {
        struct work_struct hotplug_work;
 
index 91cb0b6ec47b2f3fdb2c56212a16f31f12c6bec4..ad8897828b0cf552a47588a4ad22910430cb3a56 100644 (file)
@@ -1441,7 +1441,7 @@ static void intel_hpd_irq_handler(struct drm_device *dev,
                         hotplug_trigger, dig_hotplug_reg);
 
        spin_lock(&dev_priv->irq_lock);
-       for (i = 1; i < HPD_NUM_PINS; i++) {
+       for_each_hpd_pin(i) {
                bool long_hpd;
 
                if (!(hpd[i] & hotplug_trigger))
@@ -1477,7 +1477,7 @@ static void intel_hpd_irq_handler(struct drm_device *dev,
                queue_dig = true;
        }
 
-       for (i = 1; i < HPD_NUM_PINS; i++) {
+       for_each_hpd_pin(i) {
                if (hpd[i] & hotplug_trigger &&
                    dev_priv->hotplug.stats[i].state == HPD_DISABLED) {
                        /*
@@ -4292,7 +4292,7 @@ static void intel_hpd_irq_reenable_work(struct work_struct *work)
        intel_runtime_pm_get(dev_priv);
 
        spin_lock_irq(&dev_priv->irq_lock);
-       for (i = (HPD_NONE + 1); i < HPD_NUM_PINS; i++) {
+       for_each_hpd_pin(i) {
                struct drm_connector *connector;
 
                if (dev_priv->hotplug.stats[i].state != HPD_DISABLED)
@@ -4450,7 +4450,7 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
        struct drm_connector *connector;
        int i;
 
-       for (i = 1; i < HPD_NUM_PINS; i++) {
+       for_each_hpd_pin(i) {
                dev_priv->hotplug.stats[i].count = 0;
                dev_priv->hotplug.stats[i].state = HPD_ENABLED;
        }