brcmfmac: print firmware reported general status errors
authorRafał Miłecki <rafal@milecki.pl>
Thu, 21 Feb 2019 10:33:25 +0000 (11:33 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 28 Feb 2019 08:27:59 +0000 (10:27 +0200)
Firmware may report general errors using a special message type. Add
basic support for it by simply decoding & printing an error number.

A sample situation in which firmware reports a buf error:
CONSOLE: 027084.733 no host response IOCTL buffer available..so fail the request
will now produce a "Firmware reported general error: 9" on the host.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c

index d711dc8ed606c927488871b84b106b862bfc6f0c..d3780eae7f19cdb1f669e12bec82817fd09933fa 100644 (file)
@@ -134,6 +134,14 @@ struct msgbuf_completion_hdr {
        __le16                          flow_ring_id;
 };
 
+/* Data struct for the MSGBUF_TYPE_GEN_STATUS */
+struct msgbuf_gen_status {
+       struct msgbuf_common_hdr        msg;
+       struct msgbuf_completion_hdr    compl_hdr;
+       __le16                          write_idx;
+       __le32                          rsvd0[3];
+};
+
 /* Data struct for the MSGBUF_TYPE_RING_STATUS */
 struct msgbuf_ring_status {
        struct msgbuf_common_hdr        msg;
@@ -1194,6 +1202,18 @@ brcmf_msgbuf_process_rx_complete(struct brcmf_msgbuf *msgbuf, void *buf)
        brcmf_netif_rx(ifp, skb);
 }
 
+static void brcmf_msgbuf_process_gen_status(struct brcmf_msgbuf *msgbuf,
+                                           void *buf)
+{
+       struct msgbuf_gen_status *gen_status = buf;
+       struct brcmf_pub *drvr = msgbuf->drvr;
+       int err;
+
+       err = le16_to_cpu(gen_status->compl_hdr.status);
+       if (err)
+               bphy_err(drvr, "Firmware reported general error: %d\n", err);
+}
+
 static void brcmf_msgbuf_process_ring_status(struct brcmf_msgbuf *msgbuf,
                                             void *buf)
 {
@@ -1273,6 +1293,10 @@ static void brcmf_msgbuf_process_msgtype(struct brcmf_msgbuf *msgbuf, void *buf)
 
        msg = (struct msgbuf_common_hdr *)buf;
        switch (msg->msgtype) {
+       case MSGBUF_TYPE_GEN_STATUS:
+               brcmf_dbg(MSGBUF, "MSGBUF_TYPE_GEN_STATUS\n");
+               brcmf_msgbuf_process_gen_status(msgbuf, buf);
+               break;
        case MSGBUF_TYPE_RING_STATUS:
                brcmf_dbg(MSGBUF, "MSGBUF_TYPE_RING_STATUS\n");
                brcmf_msgbuf_process_ring_status(msgbuf, buf);