msm: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[small fixup for unused variable warning]
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/msm_perf.c b/drivers/gpu/drm/msm/msm_perf.c
index 5ab21bd2decbd00cde1d1ee08654e0ab562b1eb7..95948cfe7a12089afff1a01f9be2fe37035261b8 100644 (file)
--- a/drivers/gpu/drm/msm/msm_perf.c
+++ b/drivers/gpu/drm/msm/msm_perf.c
@@ -205,7 +205,6 @@ int msm_perf_debugfs_init(struct drm_minor *minor)
 {
        struct msm_drm_private *priv = minor->dev->dev_private;
        struct msm_perf_state *perf;
-       struct dentry *ent;
 
        /* only create on first minor: */
        if (priv->perf)
@@ -220,19 +219,9 @@ int msm_perf_debugfs_init(struct drm_minor *minor)
        mutex_init(&perf->read_lock);
        priv->perf = perf;
 
-       ent = debugfs_create_file("perf", S_IFREG | S_IRUGO,
-                       minor->debugfs_root, perf, &perf_debugfs_fops);
-       if (!ent) {
-               DRM_ERROR("Cannot create /sys/kernel/debug/dri/%pd/perf\n",
-                               minor->debugfs_root);
-               goto fail;
-       }
-
+       debugfs_create_file("perf", S_IFREG | S_IRUGO, minor->debugfs_root,
+                           perf, &perf_debugfs_fops);
        return 0;
-
-fail:
-       msm_perf_debugfs_cleanup(priv);
-       return -1;
 }
 
 void msm_perf_debugfs_cleanup(struct msm_drm_private *priv)

diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
index d21172933d92804f7847b9a1b4d1ec14001c8570..480d810037ce718b7d62598c961199643cf0c909 100644 (file)
--- a/drivers/gpu/drm/msm/msm_rd.c
+++ b/drivers/gpu/drm/msm/msm_rd.c
@@ -244,8 +244,6 @@ static void rd_cleanup(struct msm_rd_state *rd)
 static struct msm_rd_state *rd_init(struct drm_minor *minor, const char *name)
 {
        struct msm_rd_state *rd;
-       struct dentry *ent;
-       int ret = 0;
 
        rd = kzalloc(sizeof(*rd), GFP_KERNEL);
        if (!rd)
@@ -258,20 +256,10 @@ static struct msm_rd_state *rd_init(struct drm_minor *minor, const char *name)
 
        init_waitqueue_head(&rd->fifo_event);
 
-       ent = debugfs_create_file(name, S_IFREG | S_IRUGO,
-                       minor->debugfs_root, rd, &rd_debugfs_fops);
-       if (!ent) {
-               DRM_ERROR("Cannot create /sys/kernel/debug/dri/%pd/%s\n",
-                               minor->debugfs_root, name);
-               ret = -ENOMEM;
-               goto fail;
-       }
+       debugfs_create_file(name, S_IFREG | S_IRUGO, minor->debugfs_root, rd,
+                           &rd_debugfs_fops);
 
        return rd;
-
-fail:
-       rd_cleanup(rd);
-       return ERR_PTR(ret);
 }
 
 int msm_rd_debugfs_init(struct drm_minor *minor)