ASoC: uniphier: Drop superfluous PCM preallocation error checks
authorTakashi Iwai <tiwai@suse.de>
Mon, 4 Feb 2019 15:40:55 +0000 (16:40 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Feb 2019 17:29:39 +0000 (18:29 +0100)
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant.  Drop it.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/soc/uniphier/aio-dma.c

index 4ec6b65bfb4498facd55d168f13e1daa7e029fa8..fa001d3c1a88705e729a2db401583067c52cd3fd 100644 (file)
@@ -235,10 +235,11 @@ static int uniphier_aiodma_new(struct snd_soc_pcm_runtime *rtd)
        if (ret)
                return ret;
 
-       return snd_pcm_lib_preallocate_pages_for_all(pcm,
+       snd_pcm_lib_preallocate_pages_for_all(pcm,
                SNDRV_DMA_TYPE_DEV, dev,
                uniphier_aiodma_hw.buffer_bytes_max,
                uniphier_aiodma_hw.buffer_bytes_max);
+       return 0;
 }
 
 static void uniphier_aiodma_free(struct snd_pcm *pcm)