x86/irq: Fix kbuild warning in smp_irq_move_cleanup_interrupt()
authorPrarit Bhargava <prarit@redhat.com>
Mon, 13 Jan 2014 13:40:20 +0000 (08:40 -0500)
committerIngo Molnar <mingo@kernel.org>
Mon, 13 Jan 2014 14:08:37 +0000 (15:08 +0100)
Fengguang Wu's 0day kernel build service reported the following build warning:

  arch/x86/kernel/apic/io_apic.c:2211
  smp_irq_move_cleanup_interrupt() warn: always true condition '(irq <= -1) => (0-u32max <= (-1))'

because irq is defined as an unsigned int instead of an int.
Fix this trivial error by redefining irq as a signed int.  The
remaining consumers of the int are okay.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Link: http://lkml.kernel.org/r/1389620420-7110-1-git-send-email-prarit@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/apic/io_apic.c

index 6df0b660753b6e628b55882740948082b7da2970..a43f068ebec1c0867f91d2de2eff54cc5a89e8d4 100644 (file)
@@ -2202,7 +2202,7 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
 
        me = smp_processor_id();
        for (vector = FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) {
-               unsigned int irq;
+               int irq;
                unsigned int irr;
                struct irq_desc *desc;
                struct irq_cfg *cfg;