kprobes: Remove pointless BUG_ON() from add_new_kprobe()
authorMasami Hiramatsu <mhiramat@kernel.org>
Tue, 11 Sep 2018 10:19:43 +0000 (19:19 +0900)
committerIngo Molnar <mingo@kernel.org>
Wed, 12 Sep 2018 06:01:15 +0000 (08:01 +0200)
Before calling add_new_kprobe(), aggr_probe's GONE
flag and kprobe GONE flag are cleared. We don't need
to worry about that flag at this point.

Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S . Miller <davem@davemloft.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Naveen N . Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/153666118298.21306.4915366706875652652.stgit@devbox
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/kprobes.c

index d1edd8d5641ecf6e81f9d2d64f00fd47c452de5c..231569e1e2c8fa827ed3c04d11170a88c84d2533 100644 (file)
@@ -1259,8 +1259,6 @@ NOKPROBE_SYMBOL(cleanup_rp_inst);
 /* Add the new probe to ap->list */
 static int add_new_kprobe(struct kprobe *ap, struct kprobe *p)
 {
-       BUG_ON(kprobe_gone(ap) || kprobe_gone(p));
-
        if (p->post_handler)
                unoptimize_kprobe(ap, true);    /* Fall back to normal kprobe */