drm/i915: Assert we do not try to wait on an invalid seqno
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 2 Jan 2018 19:25:00 +0000 (19:25 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 3 Jan 2018 17:48:00 +0000 (17:48 +0000)
We should never insert the invalid seqno into the wait tree, so assert
we do not.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: MichaƂ Winiarski <michal.winiarski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180102192500.20364-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_breadcrumbs.c

index 58c624f982d91c1383b8d51adbf7efea76eeef54..86acac010bb8c747d7aeee49aac489dccf348d5b 100644 (file)
@@ -396,6 +396,8 @@ static bool __intel_engine_add_wait(struct intel_engine_cs *engine,
        bool first, armed;
        u32 seqno;
 
+       GEM_BUG_ON(!wait->seqno);
+
        /* Insert the request into the retirement ordered list
         * of waiters by walking the rbtree. If we are the oldest
         * seqno in the tree (the first to be retired), then