[media] dvb_usb_v2: return the download ret in dvb_usb_download_firmware
authorMalcolm Priestley <tvboxspy@gmail.com>
Wed, 13 Jun 2012 21:24:32 +0000 (18:24 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 4 Aug 2012 10:56:32 +0000 (07:56 -0300)
The first being this patch, no return value from dvb_usb_download_firmware
causes system wide dead lock with COLD disconnect as system attempts to continue
to warm state.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-usb/dvb_usb_init.c

index ecc6bd25349731d8f3e627346218a13c59858f5f..0ac1a72a7d812ee546e3e420b3b69571cd3a232a 100644 (file)
@@ -62,7 +62,7 @@ static int dvb_usbv2_download_firmware(struct dvb_usb_device *d)
        if (ret < 0)
                goto err;
 
-       return 0;
+       return ret;
 err:
        pr_debug("%s: failed=%d\n", __func__, ret);
        return ret;