ALSA: hda/ca0132: fix array_size.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Mon, 14 May 2018 19:02:14 +0000 (03:02 +0800)
committerTakashi Iwai <tiwai@suse.de>
Mon, 14 May 2018 19:23:51 +0000 (21:23 +0200)
sound/pci/hda/patch_ca0132.c:5062:50-51: WARNING: Use ARRAY_SIZE
sound/pci/hda/patch_ca0132.c:5092:50-51: WARNING: Use ARRAY_SIZE

 Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

Semantic patch information:
 This makes an effort to find cases where ARRAY_SIZE can be used such as
 where there is a division of sizeof the array by the sizeof its first
 element or by any indexed element or the element type. It replaces the
 division of the two sizeofs by ARRAY_SIZE.

Generated by: scripts/coccinelle/misc/array_size.cocci

Fixes: 47cdf76e44e8 ("ALSA: hda/ca0132: Add new control changes for SBZ + R3Di")
CC: Connor McAdams <conmanx360@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_ca0132.c

index 0fa67f45241dc45cfec192e0826f2a1bb4124933..1cc4f5133645aee53537d984b985579b74d8df58 100644 (file)
@@ -5059,8 +5059,7 @@ static int ca0132_alt_svm_setting_put(struct snd_kcontrol *kcontrol,
 static int ca0132_alt_eq_preset_info(struct snd_kcontrol *kcontrol,
                                 struct snd_ctl_elem_info *uinfo)
 {
-       unsigned int items = sizeof(ca0132_alt_eq_presets)
-                               / sizeof(struct ct_eq_preset);
+       unsigned int items = ARRAY_SIZE(ca0132_alt_eq_presets);
 
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
@@ -5089,8 +5088,7 @@ static int ca0132_alt_eq_preset_put(struct snd_kcontrol *kcontrol,
        struct ca0132_spec *spec = codec->spec;
        int i, err = 0;
        int sel = ucontrol->value.enumerated.item[0];
-       unsigned int items = sizeof(ca0132_alt_eq_presets)
-                               / sizeof(struct ct_eq_preset);
+       unsigned int items = ARRAY_SIZE(ca0132_alt_eq_presets);
 
        if (sel >= items)
                return 0;