ramips: dts: rt3050: reset FE and ESW cores together
authorLech Perczak <lech.perczak@gmail.com>
Mon, 11 Dec 2023 23:22:04 +0000 (00:22 +0100)
committerHauke Mehrtens <hauke@hauke-m.de>
Tue, 2 Jan 2024 20:56:52 +0000 (21:56 +0100)
Failing to do so will cause the DMA engine to not initialize properly
and fail to forward packets between them, and in some cases will cause
spurious transmission with size exceeding allowed packet size, causing a
kernel panic.

This is behaviour of downstream driver as well, however I
haven't observed bug reports about this SoC in the wild, so this
commit's purpose is to align this chip with all other SoC's - MT7620
were already using this arrangement.

Fixes: 60fadae62b64 ("ramips: ethernet: ralink: move reset of the esw into the esw instead of fe")
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
target/linux/ramips/dts/rt3050.dtsi

index 4d70773ed1cbfa587719e7fded922ce699aa610d..d23303964f3e881850d28dea77b11c8270513bb3 100644 (file)
 
                clocks = <&sysc 11>;
 
-               resets = <&sysc 21>;
-               reset-names = "fe";
+               resets = <&sysc 21>, <&sysc 23>;
+               reset-names = "fe", "esw";
 
                interrupt-parent = <&cpuintc>;
                interrupts = <5>;
                compatible = "ralink,rt3050-esw";
                reg = <0x10110000 0x8000>;
 
-               resets = <&sysc 23>, <&sysc 24>;
-               reset-names = "esw", "ephy";
+               resets = <&sysc 24>;
+               reset-names = "ephy";
 
                interrupt-parent = <&intc>;
                interrupts = <17>;