powerpc/8xx: fix cpm_cascade() dual end of interrupt
authorChristophe Leroy <christophe.leroy@c-s.fr>
Tue, 27 Feb 2018 11:25:55 +0000 (12:25 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 13 Mar 2018 04:50:28 +0000 (15:50 +1100)
cpm_cascade() doesn't have to call eoi() as it is already called
by handle_fasteoi_irq()

And cpm_get_irq() will always return an unsigned int so the test
is useless

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/8xx/m8xx_setup.c

index e1274db53d48a54f4d2614ac9a8bcc4e213ed949..2188d691a40f1456410e0c6b5619d64d28e14afe 100644 (file)
@@ -217,13 +217,7 @@ void __noreturn mpc8xx_restart(char *cmd)
 
 static void cpm_cascade(struct irq_desc *desc)
 {
-       struct irq_chip *chip = irq_desc_get_chip(desc);
-       int cascade_irq = cpm_get_irq();
-
-       if (cascade_irq >= 0)
-               generic_handle_irq(cascade_irq);
-
-       chip->irq_eoi(&desc->irq_data);
+       generic_handle_irq(cpm_get_irq());
 }
 
 /* Initialize the internal interrupt controllers.  The number of