crypto: cavium/zip - Add missing single_release()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 4 Sep 2019 14:18:09 +0000 (14:18 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 9 Sep 2019 13:48:41 +0000 (23:48 +1000)
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.

Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics")
Cc: <stable@vger.kernel.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/zip/zip_main.c

index a8447a3cf3665b586cfd0c92a3cd6b083781a277..194624b4855bd24ff4c0a445e7ebe6fe038ebb9c 100644 (file)
@@ -593,6 +593,7 @@ static const struct file_operations zip_stats_fops = {
        .owner = THIS_MODULE,
        .open  = zip_stats_open,
        .read  = seq_read,
+       .release = single_release,
 };
 
 static int zip_clear_open(struct inode *inode, struct file *file)
@@ -604,6 +605,7 @@ static const struct file_operations zip_clear_fops = {
        .owner = THIS_MODULE,
        .open  = zip_clear_open,
        .read  = seq_read,
+       .release = single_release,
 };
 
 static int zip_regs_open(struct inode *inode, struct file *file)
@@ -615,6 +617,7 @@ static const struct file_operations zip_regs_fops = {
        .owner = THIS_MODULE,
        .open  = zip_regs_open,
        .read  = seq_read,
+       .release = single_release,
 };
 
 /* Root directory for thunderx_zip debugfs entry */