netdevsim: let net core to free netdevsim netdev
authorJiri Pirko <jiri@mellanox.com>
Tue, 9 Apr 2019 15:14:53 +0000 (17:14 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Apr 2019 18:16:59 +0000 (11:16 -0700)
No need to free it ourselves, just set the "needs_free_netdev" flag
and leave the work to net core.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/netdev.c

index cc4a5b5793fa6fb0a30ef315ac76913c4a05b191..0af38bc6d98c1a7d26c6f1bf8a47d592c444e067 100644 (file)
@@ -139,7 +139,6 @@ static void nsim_dev_release(struct device *dev)
        struct netdevsim *ns = to_nsim(dev);
 
        nsim_vfs_disable(ns);
-       free_netdev(ns->netdev);
 }
 
 static struct device_type nsim_dev_type = {
@@ -490,6 +489,7 @@ static void nsim_setup(struct net_device *dev)
        eth_hw_addr_random(dev);
 
        dev->netdev_ops = &nsim_netdev_ops;
+       dev->needs_free_netdev = true;
        dev->priv_destructor = nsim_free;
 
        dev->tx_queue_len = 0;