sfc: Do not initialise buffer in efx_alloc_special_buffer()
authorBen Hutchings <bhutchings@solarflare.com>
Tue, 18 Sep 2012 23:31:18 +0000 (00:31 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Sat, 1 Dec 2012 01:56:22 +0000 (01:56 +0000)
Currently we initialise the newly allocated buffer to all-1s, which is
important for event queues but not for descriptor queues.  And since
we also do that in efx_nic_init_eventq(), it is completely pointless
to do it here.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/nic.c

index 368659d6362aad778c74f2d53fb669d406a4725c..1327f29d086f31d58a0c56b15324ae10968d4762 100644 (file)
@@ -255,9 +255,6 @@ static int efx_alloc_special_buffer(struct efx_nic *efx,
        buffer->entries = len / EFX_BUF_SIZE;
        BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1));
 
-       /* All zeros is a potentially valid event so memset to 0xff */
-       memset(buffer->addr, 0xff, len);
-
        /* Select new buffer ID */
        buffer->index = efx->next_buffer_table;
        efx->next_buffer_table += buffer->entries;