[PATCH] oom: don't kill unkillable children or siblings
authorNick Piggin <npiggin@suse.de>
Thu, 7 Dec 2006 04:31:50 +0000 (20:31 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Thu, 7 Dec 2006 16:39:20 +0000 (08:39 -0800)
Abort the kill if any of our threads have OOM_DISABLE set.  Having this
test here also prevents any OOM_DISABLE child of the "selected" process
from being killed.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
mm/oom_kill.c

index 2e3ce3a928b97dd8eeb54b42fb6f363d15a6d2ae..bc2627deb7f925eeb24e6e7a3ef49f4a6401a1f7 100644 (file)
@@ -313,15 +313,24 @@ static int oom_kill_task(struct task_struct *p, const char *message)
        if (mm == NULL)
                return 1;
 
+       /*
+        * Don't kill the process if any threads are set to OOM_DISABLE
+        */
+       do_each_thread(g, q) {
+               if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
+                       return 1;
+       } while_each_thread(g, q);
+
        __oom_kill_task(p, message);
+
        /*
         * kill all processes that share the ->mm (i.e. all threads),
         * but are in a different thread group
         */
-       do_each_thread(g, q)
+       do_each_thread(g, q) {
                if (q->mm == mm && q->tgid != p->tgid)
                        __oom_kill_task(q, message);
-       while_each_thread(g, q);
+       while_each_thread(g, q);
 
        return 0;
 }