gpio: omap: prevent module from being unloaded while in use
authorGrygorii Strashko <grygorii.strashko@ti.com>
Thu, 25 Jun 2015 15:13:33 +0000 (18:13 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 16 Jul 2015 12:26:03 +0000 (14:26 +0200)
OMAP GPIO driver allowed to be built as loadable module, but it
doesn't set owner field in GPIO chip structure. As result,
module_get/put() API is not working and it's possible to unload
OMAP driver while in use:

  omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED

Hence, add missing configuration.

Cc: Tony Lindgren <tony@atomide.com>
Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module')
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-omap.c

index a0ad8030a7eff71a62d6abdb6a5f23962d20b72b..61a731ff9a076fccd0c9b2bdc15d3ca10ce5e21c 100644 (file)
@@ -1187,6 +1187,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
        bank->irq = res->start;
        bank->dev = dev;
        bank->chip.dev = dev;
+       bank->chip.owner = THIS_MODULE;
        bank->dbck_flag = pdata->dbck_flag;
        bank->stride = pdata->bank_stride;
        bank->width = pdata->bank_width;