net/mlx4_en: ethtool: make array modes static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 11:53:48 +0000 (12:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Sep 2019 08:29:15 +0000 (09:29 +0100)
Don't populate the array modes on the stack but instead make it
static const. Makes the object code smaller by 303 bytes.

Before:
   text    data     bss     dec     hex filename
  51240    5008    1312   57560    e0d8 mellanox/mlx4/en_ethtool.o

After:
   text    data     bss     dec     hex filename
  50937    5008    1312   57257    dfa9 mellanox/mlx4/en_ethtool.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

index 94c59939a8cff373ae1157818d342e29057ee4ad..d8313e2ee60027e9b22848d016f020051de4d065 100644 (file)
@@ -639,7 +639,7 @@ static unsigned long *ptys2ethtool_link_mode(struct ptys2ethtool_config *cfg,
 #define MLX4_BUILD_PTYS2ETHTOOL_CONFIG(reg_, speed_, ...)              \
        ({                                                              \
                struct ptys2ethtool_config *cfg;                        \
-               const unsigned int modes[] = { __VA_ARGS__ };           \
+               static const unsigned int modes[] = { __VA_ARGS__ };    \
                unsigned int i;                                         \
                cfg = &ptys2ethtool_map[reg_];                          \
                cfg->speed = speed_;                                    \