[PATCH 1/2] Never write errors to stdout from ipkg-make-index.sh
authorJo-Philipp Wich <jow@openwrt.org>
Wed, 23 Feb 2011 22:58:58 +0000 (22:58 +0000)
committerJo-Philipp Wich <jow@openwrt.org>
Wed, 23 Feb 2011 22:58:58 +0000 (22:58 +0000)
Since the output of ipkg-make-index.sh is unconditionally used to create
the Packages file, sending the errors into this file is unacceptable
(both because they are not shown to users and because they make an
invalid Packages file).

For incorrect invocation, write to stderr.
For errors from which, send to /dev/null with stdout.

Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>
SVN-Revision: 25677

scripts/ipkg-make-index.sh

index c4c46f8882c231f7ab7aeb43faf0eacf66b13180..8ae7eedc9ae3180b8c2673a881afa6e18d010651 100755 (executable)
@@ -4,11 +4,11 @@ set -e
 pkg_dir=$1
 
 if [ -z $pkg_dir ] || [ ! -d $pkg_dir ]; then
-       echo "Usage: ipkg-make-index <package_directory>"
+       echo "Usage: ipkg-make-index <package_directory>" >&2
        exit 1
 fi
 
-which md5sum 2>&1 >/dev/null || alias md5sum=md5
+which md5sum >/dev/null 2>&1 || alias md5sum=md5
 
 for pkg in `find $pkg_dir -name '*.ipk' | sort`; do
        echo "Generating index for package $pkg" >&2