x86/nmi: Fix timeout test in test_nmi_ipi()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 19 Jun 2017 10:53:04 +0000 (13:53 +0300)
committerIngo Molnar <mingo@kernel.org>
Tue, 20 Jun 2017 10:52:43 +0000 (12:52 +0200)
We're supposed to exit the loop with "timeout" set to zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Fixes: 99e8b9ca90d6 ("x86, NMI: Add NMI IPI selftest")
Link: http://lkml.kernel.org/r/20170619105304.GA23995@elgon.mountain
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/nmi_selftest.c

index 6d9582ec0324936646da2b537602ae267b6a4a64..d27f8d84c4ff70cf1fd6f5a83e0c143e809b9ccc 100644 (file)
@@ -78,7 +78,7 @@ static void __init test_nmi_ipi(struct cpumask *mask)
 
        /* Don't wait longer than a second */
        timeout = USEC_PER_SEC;
-       while (!cpumask_empty(mask) && timeout--)
+       while (!cpumask_empty(mask) && --timeout)
                udelay(1);
 
        /* What happens if we timeout, do we still unregister?? */