batman-adv: Prefix types defines with BATADV_
authorSven Eckelmann <sven@narfation.org>
Sun, 3 Jun 2012 20:19:14 +0000 (22:19 +0200)
committerAntonio Quartulli <ordex@autistici.org>
Thu, 28 Jun 2012 06:45:01 +0000 (08:45 +0200)
Reported-by: Martin Hundebøll <martin@hundeboll.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
net/batman-adv/hard-interface.c
net/batman-adv/soft-interface.c
net/batman-adv/types.h

index 340108411c4dea1544b5d2f64266ea4eb02c8752..9b1cb23ec1f499d27e088581719f297fd90b6d27 100644 (file)
@@ -196,7 +196,8 @@ int batadv_hardif_min_mtu(struct net_device *soft_iface)
                if (hard_iface->soft_iface != soft_iface)
                        continue;
 
-               min_mtu = min_t(int, hard_iface->net_dev->mtu - BAT_HEADER_LEN,
+               min_mtu = min_t(int,
+                               hard_iface->net_dev->mtu - BATADV_HEADER_LEN,
                                min_mtu);
        }
        rcu_read_unlock();
@@ -320,18 +321,18 @@ int batadv_hardif_enable_interface(struct hard_iface *hard_iface,
                    hard_iface->net_dev->name);
 
        if (atomic_read(&bat_priv->fragmentation) && hard_iface->net_dev->mtu <
-               ETH_DATA_LEN + BAT_HEADER_LEN)
+               ETH_DATA_LEN + BATADV_HEADER_LEN)
                batadv_info(hard_iface->soft_iface,
                            "The MTU of interface %s is too small (%i) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to %zi would solve the problem.\n",
                            hard_iface->net_dev->name, hard_iface->net_dev->mtu,
-                           ETH_DATA_LEN + BAT_HEADER_LEN);
+                           ETH_DATA_LEN + BATADV_HEADER_LEN);
 
        if (!atomic_read(&bat_priv->fragmentation) && hard_iface->net_dev->mtu <
-               ETH_DATA_LEN + BAT_HEADER_LEN)
+               ETH_DATA_LEN + BATADV_HEADER_LEN)
                batadv_info(hard_iface->soft_iface,
                            "The MTU of interface %s is too small (%i) to handle the transport of batman-adv packets. If you experience problems getting traffic through try increasing the MTU to %zi.\n",
                            hard_iface->net_dev->name, hard_iface->net_dev->mtu,
-                           ETH_DATA_LEN + BAT_HEADER_LEN);
+                           ETH_DATA_LEN + BATADV_HEADER_LEN);
 
        if (batadv_hardif_is_iface_up(hard_iface))
                batadv_hardif_activate_interface(hard_iface);
index e726419045e4b3091e27cecffcef18055419affc..bbbc9a93d4306f544f102f1ce78cde03c1464b14 100644 (file)
@@ -351,7 +351,7 @@ static void batadv_interface_setup(struct net_device *dev)
         */
        dev->mtu = ETH_DATA_LEN;
        /* reserve more space in the skbuff for our header */
-       dev->hard_header_len = BAT_HEADER_LEN;
+       dev->hard_header_len = BATADV_HEADER_LEN;
 
        /* generate random address */
        eth_hw_addr_random(dev);
index 053c5d4776ce4367a4512f658ac50b10e82ada8a..1d5d21ed8e8ab5da65f6ae15aa16ac5241d319b6 100644 (file)
 
 #include "packet.h"
 #include "bitarray.h"
+#include <linux/kernel.h>
 
-#define BAT_HEADER_LEN (ETH_HLEN + \
-       ((sizeof(struct unicast_packet) > sizeof(struct bcast_packet) ? \
-        sizeof(struct unicast_packet) : \
-        sizeof(struct bcast_packet))))
-
+#define BATADV_HEADER_LEN \
+       (ETH_HLEN + max(sizeof(struct unicast_packet), \
+                       sizeof(struct bcast_packet)))
 
 struct hard_iface {
        struct list_head list;