sctp: use read_lock_bh in sctp_eps_seq_show
authorXin Long <lucien.xin@gmail.com>
Sat, 10 Jun 2017 07:13:32 +0000 (15:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Jun 2017 20:22:26 +0000 (16:22 -0400)
This patch is to use read_lock_bh instead of local_bh_disable
and read_lock in sctp_eps_seq_show.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/proc.c

index 5a27d0f03df53be07ec50a245f0ce4a35c32ef76..8e34db56bc1db2a118722b5d88ab5e3f757f2fca 100644 (file)
@@ -218,8 +218,7 @@ static int sctp_eps_seq_show(struct seq_file *seq, void *v)
                return -ENOMEM;
 
        head = &sctp_ep_hashtable[hash];
-       local_bh_disable();
-       read_lock(&head->lock);
+       read_lock_bh(&head->lock);
        sctp_for_each_hentry(epb, &head->chain) {
                ep = sctp_ep(epb);
                sk = epb->sk;
@@ -234,8 +233,7 @@ static int sctp_eps_seq_show(struct seq_file *seq, void *v)
                sctp_seq_dump_local_addrs(seq, epb);
                seq_printf(seq, "\n");
        }
-       read_unlock(&head->lock);
-       local_bh_enable();
+       read_unlock_bh(&head->lock);
 
        return 0;
 }