crypto: user - fix memory leak in crypto_reportstat
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Fri, 4 Oct 2019 19:34:54 +0000 (14:34 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 10 Oct 2019 12:42:45 +0000 (23:42 +1100)
In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
leaked if crypto_reportstat_alg() fails. Required release for skb is
added.

Fixes: cac5818c25d0 ("crypto: user - Implement a generic crypto statistics")
Cc: <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/crypto_user_stat.c

index 8bad88413de163e831edc3beb374fed74a3d4dd8..1be95432fa2333711c80ed6348aca2e0ae50fd9e 100644 (file)
@@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
 drop_alg:
        crypto_mod_put(alg);
 
-       if (err)
+       if (err) {
+               kfree_skb(skb);
                return err;
+       }
 
        return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
 }