IB/cma: Fix net_dev reference leak with failed requests
authorHaggai Eran <haggaie@mellanox.com>
Thu, 27 Aug 2015 12:55:15 +0000 (15:55 +0300)
committerDoug Ledford <dledford@redhat.com>
Sun, 30 Aug 2015 22:08:28 +0000 (18:08 -0400)
When no matching listening ID is found for a given request, the net_dev
that was used to find the request isn't released.

Fixes: 0b3ca768fcb0 ("IB/cma: Use found net_dev for passive connections")
Signed-off-by: Haggai Eran <haggaie@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/cma.c

index 9b306d7b5c27241cb354be781fde9a3fb7b410ba..b1ab13f3e182bb520cc986512d11e9016ecf1362 100644 (file)
@@ -1302,6 +1302,10 @@ static struct rdma_id_private *cma_id_from_event(struct ib_cm_id *cm_id,
        bind_list = cma_ps_find(rdma_ps_from_service_id(req.service_id),
                                cma_port_from_service_id(req.service_id));
        id_priv = cma_find_listener(bind_list, cm_id, ib_event, &req, *net_dev);
+       if (IS_ERR(id_priv)) {
+               dev_put(*net_dev);
+               *net_dev = NULL;
+       }
 
        return id_priv;
 }