drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8
authorJim Qu <Jim.Qu@amd.com>
Tue, 28 Mar 2017 09:18:15 +0000 (17:18 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Mar 2017 03:55:49 +0000 (23:55 -0400)
1. security firmware loading has moved to sw init, so this code
   is useless.
2. it seems that driver could not call request_firmware on
   kernel 2.6, when S3 resume. for request firmware depends on
   userspace, at this time, userspace is freeze.

Signed-off-by: Jim Qu <Jim.Qu@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c

index 5e090904addec057426799a21268d7deb3e27a7a..1c7e6c28f93ae68b5cef862b239b6806b0b44b8d 100644 (file)
@@ -840,9 +840,6 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
                const struct common_firmware_header *header;
                struct amdgpu_firmware_info *ucode = NULL;
 
-               if (CGS_UCODE_ID_SMU_SK == type)
-                       amdgpu_cgs_rel_firmware(cgs_device, CGS_UCODE_ID_SMU);
-
                if (!adev->pm.fw) {
                        switch (adev->asic_type) {
                        case CHIP_TOPAZ: