btrfs: simpilify btrfs_subvol_inherit_props
authorJeff Mahoney <jeffm@suse.com>
Fri, 10 Jun 2016 21:03:59 +0000 (17:03 -0400)
committerDavid Sterba <dsterba@suse.com>
Tue, 26 Jul 2016 11:54:22 +0000 (13:54 +0200)
We just need a superblock, but we look it up using two different
roots depending on the call site.  Let's just use a superblock
pointer initialized at the outset.

This is mostly for Coccinelle not to choke on my root push up set.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/props.c

index 36992128c7466cab65b1d8a9b71e670f32df9ac5..cf0b444ac4f306068c2da63349b3a151066118a1 100644 (file)
@@ -350,6 +350,7 @@ int btrfs_subvol_inherit_props(struct btrfs_trans_handle *trans,
                               struct btrfs_root *root,
                               struct btrfs_root *parent_root)
 {
+       struct super_block *sb = root->fs_info->sb;
        struct btrfs_key key;
        struct inode *parent_inode, *child_inode;
        int ret;
@@ -358,12 +359,11 @@ int btrfs_subvol_inherit_props(struct btrfs_trans_handle *trans,
        key.type = BTRFS_INODE_ITEM_KEY;
        key.offset = 0;
 
-       parent_inode = btrfs_iget(parent_root->fs_info->sb, &key,
-                                 parent_root, NULL);
+       parent_inode = btrfs_iget(sb, &key, parent_root, NULL);
        if (IS_ERR(parent_inode))
                return PTR_ERR(parent_inode);
 
-       child_inode = btrfs_iget(root->fs_info->sb, &key, root, NULL);
+       child_inode = btrfs_iget(sb, &key, root, NULL);
        if (IS_ERR(child_inode)) {
                iput(parent_inode);
                return PTR_ERR(child_inode);