ALSA: hda/realtek - Check amp capabilities of aa-mixer widget
authorTakashi Iwai <tiwai@suse.de>
Wed, 12 Dec 2012 17:08:52 +0000 (18:08 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Jan 2013 09:34:29 +0000 (10:34 +0100)
For handling the analog-loopback paths more generically, check the amp
capabilities of the aa-mixer widget, and create only the appropriate
mixer elements.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index 8ce0a0d4f083744a673478652eb3d0b787fcd3db..7a22ab0b047b865e1b259ed2065084a6b2ce3c71 100644 (file)
@@ -2672,6 +2672,10 @@ static int new_analog_input(struct hda_codec *codec, hda_nid_t pin,
        struct nid_path *path;
        int err, idx;
 
+       if (!nid_has_volume(codec, mix_nid, HDA_INPUT) &&
+           !nid_has_mute(codec, mix_nid, HDA_INPUT))
+               return 0; /* no need for analog loopback */
+
        path = snd_array_new(&spec->loopback_path);
        if (!path)
                return -ENOMEM;
@@ -2680,14 +2684,20 @@ static int new_analog_input(struct hda_codec *codec, hda_nid_t pin,
                return -EINVAL;
 
        idx = path->idx[path->depth - 1];
-       err = __add_pb_vol_ctrl(spec, ALC_CTL_WIDGET_VOL, ctlname, ctlidx,
+       if (nid_has_volume(codec, mix_nid, HDA_INPUT)) {
+               err = __add_pb_vol_ctrl(spec, ALC_CTL_WIDGET_VOL, ctlname, ctlidx,
                          HDA_COMPOSE_AMP_VAL(mix_nid, 3, idx, HDA_INPUT));
-       if (err < 0)
-               return err;
-       err = __add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, ctlname, ctlidx,
+               if (err < 0)
+                       return err;
+       }
+
+       if (nid_has_mute(codec, mix_nid, HDA_INPUT)) {
+               err = __add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, ctlname, ctlidx,
                          HDA_COMPOSE_AMP_VAL(mix_nid, 3, idx, HDA_INPUT));
-       if (err < 0)
-               return err;
+               if (err < 0)
+                       return err;
+       }
+
        add_loopback_list(spec, mix_nid, idx);
        return 0;
 }