brcmfmac: fix memory leak in brcmf_flowring_add_tdls_peer()

In the error paths in brcmf_flowring_add_tdls_peer() the allocated
resource should be freed.

Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c
index 7e269f9aa6070004b4185ad4549802e14a6019da..b16b367b0569662daabfeb56735ff573af593010 100644 (file)
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c
@@ -495,14 +495,18 @@ void brcmf_flowring_add_tdls_peer(struct brcmf_flowring *flow, int ifidx,
        } else {
                search = flow->tdls_entry;
                if (memcmp(search->mac, peer, ETH_ALEN) == 0)
-                       return;
+                       goto free_entry;
                while (search->next) {
                        search = search->next;
                        if (memcmp(search->mac, peer, ETH_ALEN) == 0)
-                               return;
+                               goto free_entry;
                }
                search->next = tdls_entry;
        }
 
        flow->tdls_active = true;
+       return;
+
+free_entry:
+       kfree(tdls_entry);
 }