[media] rc: Fix double free in gpio_ir_recv_remove()
authorJesper Juhl <jj@chaosbits.net>
Tue, 25 Nov 2008 13:57:54 +0000 (10:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 21 Dec 2012 18:28:58 +0000 (16:28 -0200)
Since rc_unregister_device() frees its argument there's no need to
subsequently call rc_free_device() on the same variable - in fact it's
a double free bug.
Easily fixed by just removing the rc_free_device() call.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/gpio-ir-recv.c

index 32db5f59fbc3ca7bfde811173cc4832ed4577bf3..03e3cf6eb68f602d487550c0082f72209662abc3 100644 (file)
@@ -148,7 +148,6 @@ static int __devexit gpio_ir_recv_remove(struct platform_device *pdev)
        platform_set_drvdata(pdev, NULL);
        rc_unregister_device(gpio_dev->rcdev);
        gpio_free(gpio_dev->gpio_nr);
-       rc_free_device(gpio_dev->rcdev);
        kfree(gpio_dev);
        return 0;
 }